Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9716] Support deprecated Socket.gethostbyaddr and Socket.gethostbyname #9732

Merged
merged 3 commits into from May 3, 2021

Conversation

AndreiEres
Copy link

@AndreiEres AndreiEres commented Apr 22, 2021

Fixed #9716

  • Refactored original class to add functionality to not autocorrect and suggest replacing with instance method.
  • Added Socket.gethostbyaddr and Socket.gethostbyname

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@AndreiEres AndreiEres changed the title Support deprecated Socket.gethostbyaddr and Socket.gethostbyname [Fix #9716] Support deprecated Socket.gethostbyaddr and Socket.gethostbyname Apr 22, 2021
@bbatsov bbatsov merged commit 2c39d51 into rubocop:master May 3, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented May 3, 2021

Looks good. Thanks!

One bit of feedback for down the road - it'd be nice to add to the deprecation message the Ruby version in which the deprecation has happened.

@AndreiEres AndreiEres deleted the feature/deprecated branch May 6, 2021 09:55
koic added a commit that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a cop for Ruby 3 deprecated methods in Socket
2 participants